use author fullname (fn) if it is available #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be honest all we really need for our use case is for the name string to fall back to author.fn if all the other names are undefined (in our user system only fn is defined) - and it might be less controversial than this change (which will affect a lot of existing citations!) |
|
I've had a mental sticky about this item for sometime, so we should go ahead and fix this. I go back and forth on whether to prefer the fullname in the citation or just use it as a fallback. The rational of the current implementation is to guarantee consistency in formatting. Let's talk this through. @GRG2 ? |
chuanlin2018
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an author record contains a fullname (fn) field, use that directly instead of reconstructing a full name from components (firstName, lastName and middleName).
It seems like fn should be preferred, if it has been provided, given that the algorithms for constructing a full-name representation can depend on cultural, regional or even personal preferences.